Dave wrote: > I guess I'd argue that since it is always a bug to include k_compat.h > before including something that defines the version, it would not help > to add your #ifdef, because it would only conceal that bug. What is the canonical thing that should be included before k_compat.h to ensure that the version is defined? And is there some reason why that header needs to be included other than for the version? If not, why would you characterize it as a bug? In the case of this particular driver (Computer Boards Inc. IEEE-488 card), it certainly doesn't appear that anything else was missing. It's no problem for me to patch the driver myself now that I know about the problem, and maybe the Linux-Lab people will put the change in the next release. If the proposed change isn't of value to anyone else, obviously it shouldn't be made.