Next-in-Thread Next Message

None Re: I think it's better to fix the original problem 

Forum: PCMCIA driver development
Re: Feedback suggested minor addition to k_compat.c (Eric Smith)
Re: None I think it's better to fix the original problem (David Hinds)
Date: 2000, Apr 06
From: Eric Smith brouhaha

Dave wrote:
> I guess I'd argue that since it is always a bug to include k_compat.h
> before including something that defines the version, it would not help
> to add your #ifdef, because it would only conceal that bug.

What is the canonical thing that should be included before k_compat.h to
ensure that the version is defined?  And is there some reason why that
header needs to be included other than for the version?  If not, why would
you characterize it as a bug?

In the case of this particular driver (Computer Boards Inc. IEEE-488 card),
it certainly doesn't appear that anything else was missing.

It's no problem for me to patch the driver myself now that I know about the
problem, and maybe the Linux-Lab people will put the change in the next
release.  If the proposed change isn't of value to anyone else, obviously
it shouldn't be made.

Next-in-Thread Next Message

Messages Inline: 1 All Outline: 1 2 All

1. None Re: I think it's better to fix the original problem by David Hinds, 2000, Apr 06

Add Message to: "Re: I think it's better to fix the original problem"

Members Subscribe Admin Mode Show Frames Help for HyperNews at pcmcia-cs.sourceforge.net 1.10