Next-in-Thread Next Message

None Re: I think it's better to fix the original problem 

Forum: PCMCIA driver development
Re: Feedback suggested minor addition to k_compat.c (Eric Smith)
Re: None I think it's better to fix the original problem (David Hinds)
Re: None Re: I think it's better to fix the original problem (Eric Smith)
Date: 2000, Apr 06
From: David Hinds <dhinds@pcmcia.sourceforge.org>

The canonical thing is to do:

  #include <pcmcia/config.h>
  #include <pcmcia/k_compat.h>

It is a bug, because either a file needs the kernel compatibility
definitions, or it doesn't.  If it doesn't, then it shouldn't include
k_compat.h in the first place.  If it does, then it has to define
VERSION first.  I could change this so that k_compat.h itself does the
#include.  But changing k_compat.h to do nothing if VERSION is not
defined seems pointless.

-- Dave

Next-in-Thread Next Message

Add Message to: "Re: I think it's better to fix the original problem"

Members Subscribe Admin Mode Show Frames Help for HyperNews at pcmcia-cs.sourceforge.net 1.10